Skip to content

feat(bstack): doctor + ROSTER updates for P12#5

Merged
broomva merged 1 commit into
mainfrom
feat/doctor-p12
May 6, 2026
Merged

feat(bstack): doctor + ROSTER updates for P12#5
broomva merged 1 commit into
mainfrom
feat/doctor-p12

Conversation

@broomva
Copy link
Copy Markdown
Owner

@broomva broomva commented May 6, 2026

Companion to broomva/workspace#44 (P12 governance) and broomva/persist initial commit. Extends doctor to verify P12 compliance, adds persist to ROSTER. Smoke-tested 43/46 against post-merge target.

Summary by CodeRabbit

  • Documentation

    • Updated core documentation to reflect expanded primitive model and skill roster changes across all reference materials.
  • New Features

    • Added new persist skill to the available toolkit.
    • System now supports 12 primitives (expanded from 11) and 31 skills (expanded from 29).
    • Enhanced verification processes to support the expanded primitive architecture.

…line)

Companion to broomva/workspace#44 (P12 governance) and the new
broomva/persist skill repo.

scripts/doctor.sh:
  - EXPECTED_COUNT: 11 → 12
  - Count header regex: "Eleven/11" → "Twelve/12"
  - Primitive row check loop: 1..11 → 1..12
  - P_NAMES[]: append "P12: Persistent Loop Discipline"
  - REFLEXIVE_PRIMS[]: P6 P7 P10 P11 → P6 P7 P10 P11 P12 (P12 is
    reasoning-enforced; doctor must verify its Reflexive Trigger Rule
    subsection is present in AGENTS.md)
  - SCRIPT_PATHS[]: append "skills/persist/scripts/persist.py"

scripts/bootstrap.sh:
  - SKILL_REPOS: [persist]="broomva/persist"
  - ORDERED_SKILLS: insert persist after p9 (Foundation layer)
  - Banner count: 30 → 31
  - Total reporting: 30 → 31

SKILL.md:
  - "Eleven irreducible primitives" → "Twelve"
  - "Twenty-eight curated skills" → "Twenty-nine"
  - P1–P11 → P1–P12 throughout
  - New P12 row in primitives quick-reference
  - Reflexive primitives list now includes P12

Smoke-tested locally:
  Against pre-merge local main: gaps for P10, P11, P12 (count, rows,
  sections, reflexive rules)
  Against post-merge worktree (broomva/workspace#44): 43/46 passes;
  3 gaps are skill-script paths absent from the worktree (expected,
  same pattern as earlier doctor extensions)

After workspace#44 merges and `npx skills update` propagates, doctor
reports full primitive contract compliance on a real installed
workspace.

This completes the four-PR series:
  - broomva/bookkeeping#1 (P6 replay extension) — MERGED
  - broomva/persist initial commit (P12 substrate) — pushed to main
  - broomva/workspace#44 (P12 governance) — open
  - this PR (bstack doctor + ROSTER for P12)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@broomva broomva merged commit d517b44 into main May 6, 2026
@broomva broomva deleted the feat/doctor-p12 branch May 6, 2026 16:12
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fb40edd6-454f-4bf3-bc3f-776185236d60

📥 Commits

Reviewing files that changed from the base of the PR and between c894a95 and 54de9c3.

📒 Files selected for processing (3)
  • SKILL.md
  • scripts/bootstrap.sh
  • scripts/doctor.sh

📝 Walkthrough

Walkthrough

The PR extends the skill framework from eleven to twelve primitives by introducing P12 (Persistent Loop Discipline), updates documentation and bootstrap configuration to reflect the new primitive, and adds validation logic to support the twelfth primitive in the doctor verification script.

Changes

Twelve Primitives Framework Expansion

Layer / File(s) Summary
Framework Definition
SKILL.md
Documentation updated from eleven (P1–P11) to twelve primitives (P1–P12), skill count increased from twenty-eight to twenty-nine; new P12 row added describing Persistent Loop Discipline as the broomva/persist skill.
Bootstrap Integration
scripts/bootstrap.sh
New persist skill-to-repo mapping added to SKILL_REPOS; persist appended to ORDERED_SKILLS list; installer messaging and final progress tally updated to reflect 31 skills instead of 30.
Validation & Doctor Checks
scripts/doctor.sh
CLAUDE.md primitives table validation extended to 12 entries; header check updated to accept "Twelve/12"; reflexive trigger rules expanded to include P12; new P12 mechanism path (skills/persist/scripts/persist.py) and label added to script discovery mappings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • broomva/bstack#4: Extends the primitives/doctor/bootstrap pipeline with a new P12 primitive and corresponding persist skill integration.
  • broomva/bstack#2: Introduced the initial doctor command and bootstrap logic for P1–P10, which this PR extends to support the P12 primitive.

Poem

🐰 Twelve loops now dance in perfect harmony,
Persist skill joins the family tree,
Bootstrap springs with thirty-one so bright,
Doctor validates all through the night!
Hippity-hop, the framework takes its flight! 🌟

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/doctor-p12

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant